Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmd config back to console #43033

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Add cmd config back to console #43033

merged 1 commit into from
Sep 6, 2024

Conversation

phillip-kruger
Copy link
Member

Fix #43024

Sorry about that. I accidentally removed it while removing the old dev ui commands

@phillip-kruger phillip-kruger changed the title add cmd config back to console Add cmd config back to console Sep 5, 2024
@quarkusio quarkusio deleted a comment from quarkus-bot bot Sep 5, 2024
maxandersen
maxandersen approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolio!

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

Please rebase the PR in order to pick up a CI fix

@phillip-kruger
add cmd config back to console
5102ae6 
Signed-off-by: Phillip Kruger <[email protected]>
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5102ae6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@phillip-kruger phillip-kruger merged commit 9dabb68 into quarkusio:main Sep 6, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 6, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 6, 2024
@gsmet
Copy link
Member

gsmet commented Sep 6, 2024

It's a bit more involved that I would like for a backport so I would prefer if we keep it out of 3.14/3.15.

Granted the feature existed before but we could have some weird interactions with all the changes that have been made since then (it was removed in 3.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

@maxandersen maxandersen maxandersen approved these changes

Assignees
No one assigned
Labels
area/vertx kind/enhancement New feature or request triage/flaky-test
Projects
None yet
Milestone
3.16.0.CR1
Development

Successfully merging this pull request may close these issues.

config terminal command missing
5 participants
@phillip-kruger @geoand @gsmet @maxandersen @xstefank